Rollup of 11 pull requests #145407

Kobzol · 2025-08-14T19:48:49Z

Successful merges:

Include whitespace in "remove |" suggestion and make it hidden #137872 (Include whitespace in "remove |" suggestion and make it hidden)
Fix test intrinsic-raw_eq-const-bad for big-endian #144631 (Fix test intrinsic-raw_eq-const-bad for big-endian)
cfg_select: Support unbraced expressions #145233 (cfg_select: Support unbraced expressions)
Improve tracing in bootstrap #145261 (Improve tracing in bootstrap)
Rename and document ONLY_HOSTS in bootstrap #145324 (Rename and document ONLY_HOSTS in bootstrap)
bootstrap: Fix jemalloc 64K page support for aarch64 tools #145353 (bootstrap: Fix jemalloc 64K page support for aarch64 tools)
bootstrap: Support passing --timings to cargo #145379 (bootstrap: Support passing --timings to cargo)
Rust documentation, use rustc-dev-guide :3 #145397 (Rust documentation, use rustc-dev-guide :3)
Use default_field_values in Resolver #145398 (Use default_field_values in Resolver)
cleanup: Remove useless [T].iter().last() #145401 (cleanup: Remove useless [T].iter().last())
Adjust error message grammar to be less awkward #145403 (Adjust error message grammar to be less awkward)

r? @ghost
@rustbot modify labels: rollup

The tests fail on s390x and presumably other big-endian systems, due to print of raw values and padding bytes. To fix the tests remove the raw output values in the error note with `normalize-stderr`.

When operating on expressions, `cfg_select!` can now handle expressions without braces. (It still requires braces for other things, such as items.) Expand the test coverage and documentation accordingly.

So that it is easier to see which was the last started step when a failure happens on CI.

When verbose mode is enabled, it is very hard to see the actually executed steps.

They could easily get out of sync and miss some fields. Now all steps are instrumented automatically.

…nabled

Useful for optimizing the sequencing of the compiler's own build.

…nd had no comment

…mpiler-errors cleanup: Remove useless `[T].iter().last()`

Adjust error message grammar to be less awkward r? ``@estebank``

Kobzol · 2025-08-14T19:48:55Z

@bors r+ rollup=never p=5

bors · 2025-08-14T19:48:57Z

📌 Commit 0698921 has been approved by Kobzol

It is now in the queue for this repository.

bors · 2025-08-14T23:30:14Z

⌛ Testing commit 0698921 with merge 3507a74...

bors · 2025-08-15T02:36:01Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 3507a74 to master...

rust-timer · 2025-08-15T02:39:11Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#137872	Include whitespace in "remove \|" suggestion and make it hid…	`c59f0ea6bff00180940b5041b5236f612c1b6f8d` (link)
#144631	Fix test intrinsic-raw_eq-const-bad for big-endian	`289705442b748bbd8e03bb993f17b3e745200900` (link)
#145233	cfg_select: Support unbraced expressions	`b7907e96e352637313736f8f7189f34f17d0e22d` (link)
#145261	Improve tracing in bootstrap	`8ce8d6979ebdd05e3d942c5ca1dcf974ea00786d` (link)
#145324	Rename and document `ONLY_HOSTS` in bootstrap	`1dce629e9d2e4e767d80712b43d336ad00714da3` (link)
#145353	bootstrap: Fix jemalloc 64K page support for aarch64 tools	`c8fc5c9a0cdabfaeaafdfe1fa771ac29a3d5302b` (link)
#145379	bootstrap: Support passing `--timings` to cargo	`6db819314edcc493ddd35831019eef5850840ad8` (link)
#145397	Rust documentation, use `rustc-dev-guide` :3	`d29a677fc257da9f0e505aa1e9f3b1bfc7e5ec76` (link)
#145398	Use `default_field_values` in `Resolver`	`14633aba532b98487456cd1f3a30a882c30d6dc3` (link)
#145401	cleanup: Remove useless `[T].iter().last()`	`46bee03e94de0cbc0a5a145933dd3eabfc52b1b2` (link)
#145403	Adjust error message grammar to be less awkward	`85bedd65d58d74173a8186f80a72cdbebb106d18` (link)

previous master: 898aff704d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-08-15T02:39:12Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 898aff7 (parent) -> 3507a74 (this PR)

Test differences

Show 225 test diffs

Stage 1

errors::verify_parse_array_index_offset_of_171: [missing] -> pass (J0)
errors::verify_parse_array_index_offset_of_172: pass -> [missing] (J0)
errors::verify_parse_asm_expected_comma_185: pass -> [missing] (J0)
errors::verify_parse_asm_expected_other_186: pass -> [missing] (J0)
errors::verify_parse_asm_expected_register_class_or_explicit_register_189: pass -> [missing] (J0)
errors::verify_parse_asm_expected_string_literal_187: [missing] -> pass (J0)
errors::verify_parse_asm_expected_string_literal_188: pass -> [missing] (J0)
errors::verify_parse_asm_non_abi_186: [missing] -> pass (J0)
errors::verify_parse_asm_requires_template_183: [missing] -> pass (J0)
errors::verify_parse_asm_requires_template_184: pass -> [missing] (J0)
errors::verify_parse_asm_sym_no_path_183: pass -> [missing] (J0)
errors::verify_parse_asm_underscore_input_181: [missing] -> pass (J0)
errors::verify_parse_asm_underscore_input_182: pass -> [missing] (J0)
errors::verify_parse_asm_unsupported_operand_180: [missing] -> pass (J0)
errors::verify_parse_async_impl_173: [missing] -> pass (J0)
errors::verify_parse_async_impl_174: pass -> [missing] (J0)
errors::verify_parse_at_dot_dot_in_struct_pattern_129: [missing] -> pass (J0)
errors::verify_parse_at_dot_dot_in_struct_pattern_130: pass -> [missing] (J0)
errors::verify_parse_attr_after_generic_146: pass -> [missing] (J0)
errors::verify_parse_attr_without_generics_146: [missing] -> pass (J0)
errors::verify_parse_attr_without_generics_147: pass -> [missing] (J0)
errors::verify_parse_bad_assoc_type_bounds_144: [missing] -> pass (J0)
errors::verify_parse_bad_return_type_notation_output_143: [missing] -> pass (J0)
errors::verify_parse_binder_and_polarity_178: [missing] -> pass (J0)
errors::verify_parse_binder_and_polarity_179: pass -> [missing] (J0)
errors::verify_parse_binder_before_modifiers_178: pass -> [missing] (J0)
errors::verify_parse_box_not_pat_162: [missing] -> pass (J0)
errors::verify_parse_dot_dot_dot_for_remaining_fields_131: [missing] -> pass (J0)
errors::verify_parse_dot_dot_dot_for_remaining_fields_132: pass -> [missing] (J0)
errors::verify_parse_dot_dot_dot_range_to_pattern_not_allowed_127: [missing] -> pass (J0)
errors::verify_parse_dot_dot_range_attribute_176: pass -> [missing] (J0)
errors::verify_parse_dotdotdot_rest_pattern_120: [missing] -> pass (J0)
errors::verify_parse_dotdotdot_rest_pattern_121: pass -> [missing] (J0)
errors::verify_parse_dyn_after_mut_138: [missing] -> pass (J0)
errors::verify_parse_enum_pattern_instead_of_identifier_129: pass -> [missing] (J0)
errors::verify_parse_expect_label_found_ident_152: [missing] -> pass (J0)
errors::verify_parse_expect_label_found_ident_153: pass -> [missing] (J0)
errors::verify_parse_expected_builtin_ident_168: [missing] -> pass (J0)
errors::verify_parse_expected_comma_after_pattern_field_132: [missing] -> pass (J0)
errors::verify_parse_expected_comma_after_pattern_field_133: pass -> [missing] (J0)
errors::verify_parse_expected_mut_or_const_in_raw_pointer_type_136: [missing] -> pass (J0)
errors::verify_parse_expected_mut_or_const_in_raw_pointer_type_137: pass -> [missing] (J0)
errors::verify_parse_expr_rarrow_call_175: pass -> [missing] (J0)
errors::verify_parse_fn_pointer_cannot_be_async_140: [missing] -> pass (J0)
errors::verify_parse_fn_pointer_cannot_be_async_141: pass -> [missing] (J0)
errors::verify_parse_fn_pointer_cannot_be_const_139: [missing] -> pass (J0)
errors::verify_parse_fn_pointer_cannot_be_const_140: pass -> [missing] (J0)
errors::verify_parse_generic_args_in_pat_require_turbofish_syntax_170: [missing] -> pass (J0)
errors::verify_parse_generic_args_in_pat_require_turbofish_syntax_171: pass -> [missing] (J0)
errors::verify_parse_inappropriate_default_153: [missing] -> pass (J0)
errors::verify_parse_inappropriate_default_154: pass -> [missing] (J0)
errors::verify_parse_invalid_attr_unsafe_176: [missing] -> pass (J0)
errors::verify_parse_invalid_attr_unsafe_177: pass -> [missing] (J0)
errors::verify_parse_invalid_dyn_keyword_142: [missing] -> pass (J0)
errors::verify_parse_invalid_dyn_keyword_143: pass -> [missing] (J0)
errors::verify_parse_invalid_offset_of_172: [missing] -> pass (J0)
errors::verify_parse_invalid_offset_of_173: pass -> [missing] (J0)
errors::verify_parse_kw_bad_case_166: pass -> [missing] (J0)
errors::verify_parse_lifetime_after_mut_137: [missing] -> pass (J0)
errors::verify_parse_lifetime_after_mut_138: pass -> [missing] (J0)
errors::verify_parse_lifetime_in_eq_constraint_149: [missing] -> pass (J0)
errors::verify_parse_macro_invocation_visibility_160: [missing] -> pass (J0)
errors::verify_parse_macro_invocation_visibility_161: pass -> [missing] (J0)
errors::verify_parse_macro_name_remove_bang_159: pass -> [missing] (J0)
errors::verify_parse_macro_rules_missing_bang_157: [missing] -> pass (J0)
errors::verify_parse_macro_rules_missing_bang_158: pass -> [missing] (J0)
errors::verify_parse_macro_rules_visibility_159: [missing] -> pass (J0)
errors::verify_parse_macro_rules_visibility_160: pass -> [missing] (J0)
errors::verify_parse_malformed_cfg_attr_166: [missing] -> pass (J0)
errors::verify_parse_missing_plus_in_bounds_165: pass -> [missing] (J0)
errors::verify_parse_modifier_lifetime_151: pass -> [missing] (J0)
errors::verify_parse_modifiers_and_polarity_179: [missing] -> pass (J0)
errors::verify_parse_modifiers_and_polarity_180: pass -> [missing] (J0)
errors::verify_parse_mut_on_nested_ident_pattern_124: [missing] -> pass (J0)
errors::verify_parse_mut_on_nested_ident_pattern_125: pass -> [missing] (J0)
errors::verify_parse_mut_on_non_ident_pattern_126: pass -> [missing] (J0)
errors::verify_parse_need_plus_after_trait_object_lifetime_135: [missing] -> pass (J0)
errors::verify_parse_nested_c_variadic_type_142: pass -> [missing] (J0)
errors::verify_parse_pattern_on_wrong_side_of_at_121: [missing] -> pass (J0)
errors::verify_parse_recover_import_as_use_154: [missing] -> pass (J0)
errors::verify_parse_recover_import_as_use_155: pass -> [missing] (J0)
errors::verify_parse_repeated_mut_in_pattern_126: [missing] -> pass (J0)
errors::verify_parse_repeated_mut_in_pattern_127: pass -> [missing] (J0)
errors::verify_parse_return_types_use_thin_arrow_134: [missing] -> pass (J0)
errors::verify_parse_return_types_use_thin_arrow_135: pass -> [missing] (J0)
errors::verify_parse_single_colon_import_path_155: [missing] -> pass (J0)
errors::verify_parse_single_colon_import_path_156: pass -> [missing] (J0)
errors::verify_parse_static_with_generics_169: [missing] -> pass (J0)
errors::verify_parse_static_with_generics_170: pass -> [missing] (J0)
errors::verify_parse_trailing_vert_not_allowed_120: pass -> [missing] (J0)
errors::verify_parse_underscore_literal_suffix_151: [missing] -> pass (J0)
errors::verify_parse_underscore_literal_suffix_152: pass -> [missing] (J0)
errors::verify_parse_unexpected_expr_in_pat_133: [missing] -> pass (J0)
errors::verify_parse_unexpected_lifetime_in_pattern_124: pass -> [missing] (J0)
errors::verify_parse_unknown_builtin_construct_167: [missing] -> pass (J0)
errors::verify_parse_unknown_builtin_construct_168: pass -> [missing] (J0)
errors::verify_parse_unmatched_angle_163: [missing] -> pass (J0)
errors::verify_parse_unmatched_angle_164: pass -> [missing] (J0)
errors::verify_parse_where_generics_147: [missing] -> pass (J0)
errors::verify_parse_where_generics_148: pass -> [missing] (J0)

(and 39 additional test diffs)

Additionally, 86 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-2, aarch64-msvc-2, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3507a749b365aae4eefa96ab700a9315d3280ee7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 12966.9s -> 6428.2s (-50.4%)
dist-aarch64-apple: 8023.0s -> 5388.6s (-32.8%)
dist-x86_64-apple: 11948.1s -> 9657.9s (-19.2%)
pr-check-1: 1765.3s -> 1448.5s (-17.9%)
test-various: 5989.9s -> 4946.3s (-17.4%)
x86_64-apple-2: 5134.8s -> 5851.4s (14.0%)
dist-loongarch64-linux: 5960.5s -> 6682.0s (12.1%)
i686-gnu-2: 6057.2s -> 5392.1s (-11.0%)
aarch64-gnu-llvm-19-2: 2628.0s -> 2385.1s (-9.2%)
x86_64-msvc-2: 7665.6s -> 6969.5s (-9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-15T04:28:05Z

Finished benchmarking commit (3507a74): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	39
Regressions ❌ (secondary)	0.4%	[0.2%, 0.9%]	18
Improvements ✅ (primary)	-1.4%	[-3.7%, -0.2%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-3.7%, 0.4%]	42

Max RSS (memory usage)

Results (primary -3.2%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.6%, 0.8%]	4
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-3.4%	[-4.1%, -2.7%]	2
All ❌✅ (primary)	-3.2%	[-3.2%, -3.2%]	1

Cycles

Results (primary -2.7%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.2%, 3.0%]	2
Improvements ✅ (primary)	-2.7%	[-3.3%, -2.2%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-3.3%, -2.2%]	3

Binary size

Results (primary -0.4%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.1%, 0.9%]	2
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	3
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	3

Bootstrap: 470.516s -> 469.244s (-0.27%)
Artifact size: 377.36 MiB -> 377.39 MiB (0.01%)

Kobzol · 2025-08-15T09:23:07Z

Regression caused by #145233, continuing discussion there.

@rustbot label: +perf-regression-triaged

fneddy and others added 30 commits July 30, 2025 13:53

Fix tests for big-endian

02ac116

The tests fail on s390x and presumably other big-endian systems, due to print of raw values and padding bytes. To fix the tests remove the raw output values in the error note with `normalize-stderr`.

Include whitespace in "remove |" suggestion and make it hidden

2db126d

cfg_select: Support unbraced expressions

38df158

When operating on expressions, `cfg_select!` can now handle expressions without braces. (It still requires braces for other things, such as items.) Expand the test coverage and documentation accordingly.

Store bootstrap tracing outputs to a unified directory

e6dddcb

Store latest symlink to the latest tracing output directory

c97b606

Store Chrome step trace into the tracing directory

f819729

Use shorter command span label

aad5795

Print step timings also when the stap starts to execute

3a115ba

So that it is easier to see which was the last started step when a failure happens on CI.

Replace tracing_forest with custom span formatting

c846f7c

Create a span for each executed step

1e14229

Remove ad-hoc print of executed/cached steps in verbose mode

690c781

When verbose mode is enabled, it is very hard to see the actually executed steps.

Remove manual #[instrument] annotations on steps

d403934

They could easily get out of sync and miss some fields. Now all steps are instrumented automatically.

Move tracing setup to the tracing module

604c180

Correctly show executed command name in Chrome trace

c3682b2

Always profile commands and generate Chrome profile when tracing is e…

b4a357f

…nabled

Do not create a span for cached commands

f9a4588

Create tracing directory symlink even during dry run

12828f7

Use pretty_step_name in step_graph

3e77562

Update debugging/profiling bootstrap page

a0306bf

Print created location of executed commands

6f584bc

Remove one dependency from tracing bootstrap build

0b8c6ad

bootstrap: Fix jemalloc 64K page support for aarch64 tools

ebcbcc8

bootstrap: Support passing --timings to cargo

d10a8a3

Useful for optimizing the sequencing of the compiler's own build.

bootstrap: Update completions for new --timings argument

3ecea53

Remove ONLY_HOSTS value overrides that just set the default value a…

f382d54

…nd had no comment

Rename and document ONLY_HOSTS in bootstrap

e08c755

rustc-dev-guide :3

1a226e0

Use default_field_values in Resolver

eba1596

cleanup: Remove useless [T].iter().last()

b67cd4c

Adjust error message grammar to be less awkward

65d329d

Kobzol added 2 commits August 14, 2025 21:48

Rollup merge of rust-lang#145401 - estebank:remove-useless-iter, r=co…

603ee15

…mpiler-errors cleanup: Remove useless `[T].iter().last()`

Rollup merge of rust-lang#145403 - shepmaster:grammar, r=estebank

0698921

Adjust error message grammar to be less awkward r? ``@estebank``

rustbot added the rollup A PR which is a rollup label Aug 14, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2025

bors merged commit 3507a74 into rust-lang:master Aug 15, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 15, 2025

This was referenced Aug 15, 2025

Reduce usage of compiler_for in bootstrap #145310

Open

Remove default config from bootstrap #145352

Draft

rustbot added the perf-regression Performance regression. label Aug 15, 2025

Kobzol deleted the rollup-g6yhx82 branch August 15, 2025 05:07

This was referenced Aug 15, 2025

Use default_field_values in Resolver #145398

Merged

cfg_select: Support unbraced expressions #145233

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #145407

Rollup of 11 pull requests #145407

Kobzol commented Aug 14, 2025 •

edited by rustbot

Loading

Uh oh!

Kobzol commented Aug 14, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

bors commented Aug 15, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Stage 1

Uh oh!

rust-timer commented Aug 15, 2025

Uh oh!

Kobzol commented Aug 15, 2025

Uh oh!

Uh oh!

Rollup of 11 pull requests #145407

Rollup of 11 pull requests #145407

Conversation

Kobzol commented Aug 14, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Aug 14, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

bors commented Aug 15, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Test differences

Stage 1

Job duration changes

Uh oh!

rust-timer commented Aug 15, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Aug 15, 2025

Uh oh!

Uh oh!

Kobzol commented Aug 14, 2025 •

edited by rustbot

Loading